[haiku-bugs] Re: [Haiku] #9604: PatchBay update for Haiku
- From: "korli" <trac@xxxxxxxxxxxx>
- Date: Thu, 11 Apr 2013 21:40:42 -0000
#9604: PatchBay update for Haiku
----------------------------+-------------------------
Reporter: Pete | Owner: nobody
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: Applications | Version: R1/alpha4.1
Resolution: | Keywords:
Blocked By: | Blocking: 9159
Has a Patch: 1 | Platform: All
----------------------------+-------------------------
Comment (by korli):
OK, a few things:
* #ifndef _EndpointInfo_h, _EndpointInfo_h is usually uppercased, dunno
if it's in the coding style guidelines..
* In header files, there is no blank line between license text and header
guard.
* there are a few occurrences of braces on their own lines along with a
for or a if.
* the copyright license header doesn't follow the guidelines.
* "if (box)" should be "if (box != NULL)"
* "if (producer) producer->Release();" should be on two lines
* separate #include group with a newline
Improvements to the checkstyle script are welcome too :)
--
Ticket URL: <http://dev.haiku-os.org/ticket/9604#comment:10>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
