[haiku-bugs] [Haiku] #9490: A 20KB+ Patch containing codestyle fixes for any part of the system

  • From: "mmadia" <trac@xxxxxxxxxxxx>
  • Date: Sat, 02 Mar 2013 15:46:55 -0000

#9490: A 20KB+ Patch containing codestyle fixes for any part of the system
-------------------------+------------------------------
 Reporter:  mmadia       |        Owner:  nobody
     Type:  enhancement  |       Status:  new
 Priority:  normal       |    Milestone:  R1
Component:  - General    |      Version:  R1/Development
 Keywords:               |   Blocked By:
 Blocking:               |  Has a Patch:  0
 Platform:  All          |
-------------------------+------------------------------
 This is a patch by Freeman for Google Code-In 2012, [http://www.google-
 melange.com/gci/task/view/google/gci2012/7949206 task 7949206].

 The patch mostly applies cleanly to master (currently hrev45328).
 {{{
 patching file src/system/kernel/arch/arm/arch_int.cpp
 Hunk #2 succeeded at 163 with fuzz 1.
 Hunk #3 FAILED at 190.
 Hunk #4 FAILED at 288.
 2 out of 4 hunks FAILED -- saving rejects to file
 src/system/kernel/arch/arm/arch_int.cpp.rej
 }}}

 It also looks like some trailing whitespace was introduced.  Looking at
 [https://dev.haiku-
 os.org/wiki/SubmittingPatches#Automaticwhitespacecleanup Automatic
 whitespace cleanup] will show how to remove it on  the fly.

 Would you be willing to recreate this patch using
 [https://ariejan.net/2009/10/26/how-to-create-and-apply-a-patch-with-git
 git format-patch]. This will give you a better level of recognition for
 your contribution.

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/9490>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: