[haiku-bugs] Re: [Haiku] #9489: Divide Error Exception - GPT Partition Table Driver
- From: "phoudoin" <trac@xxxxxxxxxxxx>
- Date: Thu, 04 Apr 2013 13:31:56 -0000
#9489: Divide Error Exception - GPT Partition Table Driver
----------------------------------------+----------------------------
Reporter: kallisti5 | Owner: axeld
Type: bug | Status: new
Priority: normal | Milestone: R1
Component: Partitioning Systems/GPT | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking: 9603
Has a Patch: 0 | Platform: All
----------------------------------------+----------------------------
Comment (by phoudoin):
Replying to [comment:4 axeld]:
> I don't think the VFS should even call that method with an invalid
partition. It's error prone to have these kinds of checks in every file
and partitioning system.
Somehow agree. Problem is where having a 0 block_size geometry should be
considering an error and avoid rescanning partitions?
KDiskDeviceManager::_CheckMediaStatus() ?
KDiskDeviceManager::_ScanPartitions() ?
partition system modules ?
Plus, are all partition systems necessary block-based?
The DDM is pretty agnostic here, letting the partition modules use the
device geometry information or not...
Due to the risk that any unchecked division in kernel space pose, I'm
inclined to prefer paying the price of multiple checks than the one we pay
right now, a KDL.
--
Ticket URL: <http://dev.haiku-os.org/ticket/9489#comment:5>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
