[haiku-bugs] Re: [Haiku] #9221: Breakpoints in dynamically loaded add-ons don't seem to be installed correctly
- From: "bonefish" <trac@xxxxxxxxxxxx>
- Date: Thu, 29 Nov 2012 11:06:37 -0000
#9221: Breakpoints in dynamically loaded add-ons don't seem to be installed
correctly
-------------------------------------+----------------------------
Reporter: anevilyak | Owner: anevilyak
Type: bug | Status: in-progress
Priority: normal | Milestone: R1
Component: Applications/Debugger | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
-------------------------------------+----------------------------
Comment (by bonefish):
The patch looks OK, save for a few cases of somewhat unusual formatting.
Neither for `TeamDebugger::ImageInfoPendingThread::fNext` nor for
`TeamDebugger::ImageInfoPendingThreadHashDefinition::ValueType` there's a
fixed column to be respected, so there really isn't any need to break
them. If you want to align it with the other variables/type just indent
those more. In case of `TeamDebugger::fImageInfoPendingThreads` there is a
particular column to be respected, but if that isn't possible, the common
solution is to keep the variable on the same line as the type with only a
single space in between. If that doesn't fit the 80 columns line limit,
the line can be broken (I'd indent the continuing line one additional
level).
--
Ticket URL: <http://dev.haiku-os.org/ticket/9221#comment:7>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
