[haiku-bugs] Re: [Haiku] #9189: Error of presentation the font size in the dialog 'Settings'
- From: "zooey" <trac@xxxxxxxxxxxx>
- Date: Mon, 03 Dec 2012 18:15:19 -0000
#9189: Error of presentation the font size in the dialog 'Settings'
-------------------------------------+------------------------------------
Reporter: dknoto | Owner: jackburton
Type: bug | Status: new
Priority: normal | Milestone: R1
Component: Applications/Terminal | Version: R1/Development
Resolution: | Keywords: Preferences, Font size
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
-------------------------------------+------------------------------------
Comment (by zooey):
I see possibilities for improving the patch:
* Please don't vertically align variable declaration - this just makes it
harder to insert/remove declarations at some later time (and it doesn't
follow our styleguide).
* With the static array, the code for inserting a menu item is required at
three different places. I'd recommend to use some vector class instead
(e.g. BList, BPrivate::Array or maybe even std::vector), to which the
selected menu size could just be added up front and then the loop could
just iterate over all the items and add them.
Considering the actual problem: I personally don't think using a menu for
font size selection makes much sense in the first place - I'd prefer to be
able to select any font size I wish.
--
Ticket URL: <http://dev.haiku-os.org/ticket/9189#comment:3>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
