[haiku-bugs] Re: [Haiku] #8902: Crash upon closing, after rapidly scrolling through many large photos

  • From: "axeld" <trac@xxxxxxxxxxxx>
  • Date: Tue, 03 Mar 2015 13:52:22 -0000

#8902: Crash upon closing, after rapidly scrolling through many large photos
--------------------------------------+----------------------------
   Reporter:  mmadia                  |      Owner:  axeld
       Type:  bug                     |     Status:  assigned
   Priority:  normal                  |  Milestone:  R1
  Component:  Applications/ShowImage  |    Version:  R1/Development
 Resolution:                          |   Keywords:
 Blocked By:                          |   Blocking:  7095
Has a Patch:  1                       |   Platform:  All
--------------------------------------+----------------------------

Comment (by axeld):

 Thanks for your contribution! The patch looks good, and seems to hit the
 problem on the nail.
 I have some minor complaints, however:
 - Why not use fQueue.front() instead of *begin()?
 - I would never ask for a specific error code when trying to bail out of
 an otherwise endless loop. Just imagine you don't have the privileges to
 use find_thread() in a future Haiku, and get \ `B_PERMISSION_DENIED` back?
 - Is there maybe another way than to identify the threads by name?
 - Is the window already closed at that time? Otherwise it might not be a
 nice user experience.

--
Ticket URL: <https://dev.haiku-os.org/ticket/8902#comment:4>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: