[haiku-bugs] Re: [Haiku] #8831: input_server shouldn't use pointers as a cookie
- From: "leavengood" <trac@xxxxxxxxxxxx>
- Date: Sat, 04 Aug 2012 16:18:17 -0000
#8831: input_server shouldn't use pointers as a cookie
------------------------------------+----------------------------
Reporter: xyzzy | Owner: korli
Type: bug | Status: new
Priority: normal | Milestone: R1
Component: Servers/input_server | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 0 | Platform: All
------------------------------------+----------------------------
Comment (by leavengood):
Looking more at the input_server code it already maintains a list of input
methods, so line 628 could be changed to look for the input method based
on the cookie (by comparing the pointer), removing the dangerous pointer
usage. Then the cookie could be changed to an ID without too much trouble
I think. But that would not be as big of a priority once the dangerous
pointer usage is removed.
There is plenty of padding in BInputServerMethod to add a cookie, which as
I suggested could be generated in a static method of BInputServerMethod.
--
Ticket URL: <http://dev.haiku-os.org/ticket/8831#comment:7>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
