[haiku-bugs] Re: [Haiku] #8831: input_server shouldn't use pointers as a cookie

  • From: "leavengood" <trac@xxxxxxxxxxxx>
  • Date: Sat, 04 Aug 2012 16:10:06 -0000

#8831: input_server shouldn't use pointers as a cookie
------------------------------------+----------------------------
   Reporter:  xyzzy                 |      Owner:  korli
       Type:  bug                   |     Status:  new
   Priority:  normal                |  Milestone:  R1
  Component:  Servers/input_server  |    Version:  R1/Development
 Resolution:                        |   Keywords:
 Blocked By:                        |   Blocking:
Has a Patch:  0                     |   Platform:  All
------------------------------------+----------------------------

Comment (by leavengood):

 I don't see any real reason why it can't be just an int ID, beyond the
 time needed to make the change and test it.

 And given that Alex has shown it does use the pointer in a dangerous way,
 we probably should change it.

 If the input methods and ID generation would be all internal to the
 input_server, a static method would do the job to get unique IDs.

 Maybe a hash_map could be used as well to speed up looking for input
 methods based on the cookie.

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/8831#comment:6>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: