[haiku-bugs] Re: [Haiku] #8670: Improved zoom button behavior
- From: "ejno1" <trac@xxxxxxxxxxxx>
- Date: Tue, 02 Jul 2013 16:55:53 -0000
#8670: Improved zoom button behavior
---------------------------------------+----------------------------
Reporter: mmadia | Owner: siarzhuk
Type: enhancement | Status: assigned
Priority: normal | Milestone: R1
Component: Applications/StyledEdit | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking: 8665
Has a Patch: 1 | Platform: All
---------------------------------------+----------------------------
Comment (by ejno1):
Hi axeld, thanks for the feedback.
The window shouldn't become larger than the screen because I clamp it
here:
`min_c(max_c(width, 256.f), fullWidth)`
I agree about the word wrap; I didn't think of that. I'll try to implement
it when I have access to my other computer in a week or so. I did not
resize vertically because of the suggestion in the ticket, but I'll add
that as well.
Replying to [comment:4 axeld]:
> Thanks for your patch! It goes into the right direction, however, it
does not deal gracefully with lines longer than the screen resolution; the
StyledEdit window should never be larger than the screen.
>
> Furthermore, I'm not sure if it really makes sense to disable word wrap,
and then do the resize -- there are usually complete paragraphs in such
documents. In word wrap mode, I think it makes the most sense to keep the
current window width, and only resize the height to make it fit the
contents. Only in non-word wrap mode, the current method should be applied
for the width, but additionally, the height should be changed such that
the windows is as large as needed to show all contents.
--
Ticket URL: <http://dev.haiku-os.org/ticket/8670#comment:5>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
