[haiku-bugs] Re: [Haiku] #8457: Blank screen after boot on Radeon Mobility 4670 HD

  • From: "kvark" <trac@xxxxxxxxxxxx>
  • Date: Tue, 10 Apr 2012 11:30:01 -0000

#8457: Blank screen after boot on Radeon Mobility 4670 HD
   Reporter:  kvark                       |      Owner:  kallisti5
       Type:  bug                         |     Status:  new
   Priority:  normal                      |  Milestone:  R1
  Component:  Drivers/Graphics/radeon_hd  |    Version:  R1/Development
 Resolution:                              |   Keywords:  blank radeon
 Blocked By:                              |   Blocking:
Has a Patch:  0                           |   Platform:  x86

Comment (by kvark):

 Replying to [comment:9 kallisti5]:
 > That memory allocated on 170 isn't guaranteed to exist after the
 function exits... consider it me not knowing any better.
 > I'm working on a fix and will push it shortly.

 Could you explain the fix for me? "timing" is a structure that was
 allocated on the stack:
 display_timing timing;
 Upon assignment to "mode->timing" the default copy operator will be
 called, and the memory will be copied. There is no memory leak here:
 mode->timing = timing;
 Hence, despite the fact there is a logic in your fix (why create a
 variable on the stack if you can fill the destination via a pointer), it
 does not change the functionality.

Ticket URL: <http://dev.haiku-os.org/ticket/8457#comment:11>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: