[haiku-bugs] Re: [Haiku] #8449: TODO taking read only volumes into account in src/add-ons/kernel/file_systems/ntfs/fs_func.c

  • From: "bonefish" <trac@xxxxxxxxxxxx>
  • Date: Sat, 07 Apr 2012 13:24:16 -0000

#8449: TODO taking read only volumes into account in src/add-
ons/kernel/file_systems/ntfs/fs_func.c
---------------------------------+----------------------------
   Reporter:  kag_anil           |      Owner:  3dEyes
       Type:  enhancement        |     Status:  new
   Priority:  normal             |  Milestone:  R1
  Component:  File Systems/NTFS  |    Version:  R1/alpha3
 Resolution:                     |   Keywords:  NTFS, gsoc2012
 Blocked By:                     |   Blocking:
Has a Patch:  1                  |   Platform:  All
---------------------------------+----------------------------

Comment (by bonefish):

 - You apparently missed that `B_NO_ERROR == B_OK`, that is your
 `checkReadOnly()` returns the same value regardless of whether the device
 is readable or writable.
  - The name of `checkReadOnly()` doesn't agree with our coding style, nor
 does the name of the local variable `rdOnlyCheck`.
  - There's no point in setting `result`, since the value is overwritten a
 few lines below anyway.
  - If you solve a TODO, the TODO comment should be removed.
  - Your patch introduces lines with trailing white space.
  - Patches should be created with `git format-patch`.

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/8449#comment:2>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: