[haiku-bugs] Re: [Haiku] #8447: TextView GetText() doesn't straddle the "Gap" properly
- From: "jackburton" <trac@xxxxxxxxxxxx>
- Date: Fri, 19 Sep 2014 06:03:44 -0000
#8447: TextView GetText() doesn't straddle the "Gap" properly
----------------------------------+----------------------------
Reporter: Pete | Owner: axeld
Type: bug | Status: new
Priority: critical | Milestone: R1/alpha5
Component: Kits/Interface Kit | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking: 11132
Has a Patch: 1 | Platform: All
----------------------------------+----------------------------
Comment (by jackburton):
It's been a while since I last touched that code, but it seems to me that
"offset" should be added to the second parameter of the second call to
memcpy(), like we do for the first.
IOW:
{{{
memcpy(buffer, fBuffer + offset, beforeLen);
memcpy(buffer + beforeLen, fBuffer + fGapIndex + fGapCount + offset,
afterLen);
}}}
Otherwise the code wouldn't work with offset != 0.
--
Ticket URL: <https://dev.haiku-os.org/ticket/8447#comment:9>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
