[haiku-bugs] Re: [Haiku] #8376: Audio CD CDDB Tracker KDL GCC4hybrid

  • From: "ttcoder" <trac@xxxxxxxxxxxx>
  • Date: Mon, 19 May 2014 20:28:11 -0000

#8376: Audio CD CDDB Tracker KDL GCC4hybrid
---------------------------------+----------------------------
   Reporter:  shaka              |      Owner:  bga
       Type:  bug                |     Status:  new
   Priority:  normal             |  Milestone:  R1
  Component:  File Systems/cdda  |    Version:  R1/Development
 Resolution:                     |   Keywords:
 Blocked By:                     |   Blocking:
Has a Patch:  0                  |   Platform:  x86
---------------------------------+----------------------------

Comment (by ttcoder):

 Neophyte question..

 Shouldn't `cdda_write_fs_stat()` call `notify_entry_moved()` (or maybe an
 equivalent function dedicated to notifying changes in '''volume''' names
 rather than plain file names) ?

 The notification is made in the case of invididual track renamings in
 cdda_rename() here,
 http://cgit.haiku-os.org/haiku/tree/src/add-
 ons/kernel/file_systems/cdda/kernel_interface.cpp#n1816

 but not for CD volume renaming in cdda_write_fs_stat() here..
 http://cgit.haiku-os.org/haiku/tree/src/add-
 ons/kernel/file_systems/cdda/kernel_interface.cpp#n1542

 Thought about asking that question since I remembered about this ticket
 (Tracker not being always notified of a CD volume name change).. Though I
 didn't witness it myself.. Is it normal to '''not''' notify volume name
 changes ?

--
Ticket URL: <https://dev.haiku-os.org/ticket/8376#comment:6>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: