[haiku-bugs] Re: [Haiku] #7611: [ipro1000] is broken in VirtualBox since r41815
- From: "tonestone57" <trac@xxxxxxxxxxxx>
- Date: Sun, 05 Jun 2011 19:27:59 -0000
#7611: [ipro1000] is broken in VirtualBox since r41815
----------------------------------------+----------------------------
Reporter: diver | Owner: nobody
Type: bug | Status: new
Priority: normal | Milestone: R1
Component: Drivers/Network/ipro1000 | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 0 | Platform: All
----------------------------------------+----------------------------
Comment (by tonestone57):
@modeenf, thanks for reverting in r41940. Please fix on your computer
before committing. Test with all 3 VirtualBox adapters to confirm.
@Axel, Ok, thanks for that info.
I checked the revision log and saw the FreeBSD driver imported and not
changed.
First by hugosantos, r21087 without changing in any following commits.
2nd, by Axel, r22991 but could not tell if import only or if changed
because you appear to have done everything in one commit (I believe minor
changes?) and 3rd by julun, r29246 with changes only to coding style in
following commit. In all previous cases, the changes to the original BSD
driver were zero to minor compared to what first seemed like Modeen's
major driver rewrite though part of those changes could be from BSD driver
update. Modeen also imported BSD driver and made changes to it in 1
commit making it impossible to follow.
@modeenf & others, it is best to import the original BSD driver into trunk
first and then apply changes/fixes in following commit(s). That makes it
better and easier for others to see what is going on. Refer to r29246
(import) & r29247 (changes) to see the proper and clean way of handling
BSD drivers.
--
Ticket URL: <http://dev.haiku-os.org/ticket/7611#comment:15>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
