[haiku-bugs] Re: [Haiku] #7430: MediaPlayer: Cover image / artwork
- From: "shinta" <trac@xxxxxxxxxxxx>
- Date: Sat, 23 Apr 2011 16:06:39 -0000
#7430: MediaPlayer: Cover image / artwork
----------------------------------------+----------------------------
Reporter: shinta | Owner: stippi
Type: enhancement | Status: closed
Priority: normal | Milestone: R1
Component: Applications/MediaPlayer | Version: R1/Development
Resolution: fixed | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
----------------------------------------+----------------------------
Comment (by shinta):
Replying to [comment:13 stippi]:
> BTW, I just realized that some handling of music versus video clips in
MediaPlayer should be broken now. When album art is present, MediaPlayer
will consider the clip as video now. For example, this will break the
window placement and automatic playlist saving features which depends on
the clip type.
Is your mention related to MainWin::GetQuitMessage()?
{{{
if (!fHasVideo && fHasAudio) {
// store playlist, current index and position if this is
audio
BMessage playlistArchive;
BAutolock controllerLocker(fController);
playlistArchive.AddInt64("position",
fController->TimePosition());
controllerLocker.Unlock();
if (!fPlaylist)
return;
BAutolock playlistLocker(fPlaylist);
if (fPlaylist->Archive(&playlistArchive) != B_OK
|| playlistArchive.AddInt32("index",
fPlaylist->CurrentItemIndex()) != B_OK
|| message->AddMessage("playlist",
&playlistArchive) != B_OK) {
fprintf(stderr, "Failed to store current
playlist.\n");
}
}
}}}
I wonder why current index and position is saved only if audio.
--
Ticket URL: <http://dev.haiku-os.org/ticket/7430#comment:16>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
