#7416: MediaPlayer's "Extra Media Binding Feature" ----------------------------------------+---------------------------- Reporter: shinta | Owner: stippi Type: enhancement | Status: new Priority: normal | Milestone: R1 Component: Applications/MediaPlayer | Version: R1/Development Resolution: | Keywords: Blocked By: | Blocking: Has a Patch: 1 | Platform: All ----------------------------------------+---------------------------- Comment (by stippi): Thanks for the patch, the feature is definitely cool, I really like it. However, the implementation could be a lot more powerful. First of all, I don't like that this happens in the Controller. When you add for example all files in a directory to the playlist, the combined file will play twice. Also, it does not cover all use cases that could be covered: I have one movie with both audio and video, and then one extra audio file with a different language for the same movie. These tracks would not bind with your implementation. In a similar use case, I have two files of the same movie, one is a low quality English version, the other is a high quality german version. I would love to be able to watch the high quality German video with the audio track from the English movie file. Again a situation that is not supported. A similar situation would be one movie file and many separate audio files for each language of the movie. I think what should happen is that binding takes place at the playlist level. This would take care of the first issue. Then MediaFileTrackSupplier could be changed to combine the tracks of an arbitrary number of BMediaFiles. The binding should also not only take the file name into account, but also the duration as an additional indication whether binding is possible at all. Remember that the same movie might be stored with different frame rates and the audio could not be matched in this case. Last but not least, the patch contains a few coding style violations with regards to spacing around parenthesis. Would be nice to have those addressed, in case you want to keep working on the patch. Thanks in any case! -- Ticket URL: <http://dev.haiku-os.org/ticket/7416#comment:3> Haiku <http://dev.haiku-os.org> Haiku - the operating system.