[haiku-bugs] Re: [Haiku] #7352: Removing goto from boot loader main.cpp

  • From: "axeld" <trac@xxxxxxxxxxxx>
  • Date: Wed, 09 Mar 2011 09:11:33 -0000

#7352: Removing goto from boot loader main.cpp
----------------------------------+----------------------------
   Reporter:  Finder              |      Owner:  axeld
       Type:  enhancement         |     Status:  closed
   Priority:  normal              |  Milestone:  R1
  Component:  System/Boot Loader  |    Version:  R1/Development
 Resolution:  invalid             |   Keywords:  goto
 Blocked By:                      |   Blocking:
Has a Patch:  1                   |   Platform:  All
----------------------------------+----------------------------
Changes (by axeld):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 While goto should be avoided generally, using goto to bail out like this,
 and do proper cleanup is perfectly fine IMO, and it's actually easier to
 follow than your code.
 Thanks for your patch, anyway, though!

 Just look at src/system/kernel/fs/vfs.cpp if you want to shudder a bit
 more :-)

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/7352#comment:3>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: