[haiku-bugs] Re: [Haiku] #7132: Deskbar Resize Team Icons
- From: "axeld" <trac@xxxxxxxxxxxx>
- Date: Fri, 21 Jan 2011 17:54:31 -0000
#7132: Deskbar Resize Team Icons
-----------------------------------+------------------------------
Reporter: jscipione | Owner: axeld
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: Applications/Deskbar | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Has a Patch: 1
Platform: All | Blocking:
-----------------------------------+------------------------------
Comment (by axeld):
I'm not sure I like the idea in general, as the Deskbar looks quite clumsy
with larger icon sizes, there are also a number of minor issues with your
patch:
* When a new application is launched, the menu entry is only as large as
the text, and only suddenly grows bigger a bit later -- this doesn't look
good.
* The icon size choices are pretty arbitrary, and could probably use a few
in-between sizes, like 24x24. I would also like to actually see the size
on screen, like in the Tracker icon menu.
* It doesn't work for the horizontal layout, but never tells you (ie. it
won't even disable the settings).
* It would look much better if the other icons, as well as the leaf would
scale as well. At least for the tray this probably cannot be done in a
compatible way (haven't given it much thought, though).
* An option to change the width as well would make sense, as the whole
thing looks strange when its so narrow.
* I would not store the internal (1) but the actual size (16). One could
make the size automatically depend on the font size used by default.
* The slider should also set its modification message in order to have a
live update (instead of only when you release the mouse button).
* There are some minor coding style issues: in BarApp.cpp line 303 there
is no need to wrap the line as the resulting line isn't even 80 characters
wide (there are other lines there that have the same fault, though). Line
729 needs curly braces, as the statement in the if-clause is more than one
line long.
The TBarApp::FetchAppIcon() method could be simplified a bit this way:
{{{
icon_size size = fBarView->Vertical() && icon->Bounds().IntegerHeight() >
15 ? B_LARGE_ICON : B_MINI_ICON;
}}}
However, this is overridden anyway when you pass 32 bit bitmaps, so you
can just always specify B_LARGE_ICON. The rest of the patch looks good
IMO.
--
Ticket URL: <http://dev.haiku-os.org/ticket/7132#comment:2>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
