[haiku-bugs] Re: [Haiku] #7078: Allowing shortcuts without the B_COMMAND_KEY modifier
- From: "axeld" <trac@xxxxxxxxxxxx>
- Date: Sun, 09 Jan 2011 22:14:16 -0000
#7078: Allowing shortcuts without the B_COMMAND_KEY modifier
---------------------------------+--------------------------------
Reporter: leavengood | Owner: leavengood
Type: enhancement | Status: assigned
Priority: normal | Milestone: R1/alpha3
Component: Kits/Interface Kit | Version: R1/alpha2
Resolution: | Keywords: menus, shortcuts
Blocked By: | Has a Patch: 1
Platform: All | Blocking:
---------------------------------+--------------------------------
Comment (by axeld):
I think shortcuts in menu without a modifier should stay an exception. I
wouldn't even mind to only have that for the function keys per style
guide.
I have a few comments, though:
* B_NO_MODIFIER does not belong to InterfaceDefs.h. It should be a special
flag for use with AddShortcut(); it does not have any meaning outside of
this call. In any case, I would go for a larger value, not just the next
available spot.
* Constraining the allowed keys to the F-keys would considerably ease the
check whether or not a shortcut key had been pressed. Besides that, I
don't think the speed is really an issue here. You shouldn't be able to
let a computer sweat with typing alone these days :)
* I'm not sure if a check for "modifiers == 0" will work as expected. IIRC
things like the num lock or such things may be part in the modifiers as
well (or are those masked out before?).
* "return else return" is bad style and should be avoided; the "else" is
superfluous and confusing.
* In general, I'm not a friend of using the F-keys for shortcuts, as they
are pretty much meaningless keys, and far away from your hands. Their use
should be restricted somehow via a style guide.
--
Ticket URL: <http://dev.haiku-os.org/ticket/7078#comment:4>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
