[haiku-bugs] Re: [Haiku] #7002: Context menu for TextInput
- From: "stippi" <trac@xxxxxxxxxxxx>
- Date: Sun, 19 Dec 2010 12:35:33 -0000
#7002: Context menu for TextInput
--------------------------+------------------------------------------------
Reporter: dancxjo | Owner: axeld
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: | Version: R1/Development
Kits/Interface Kit | Keywords: context menu text edit textinput
Resolution: | Has a Patch: 1
Blocked By: | Blocking:
Platform: All |
--------------------------+------------------------------------------------
Comment (by stippi):
Patch looks mostly Ok and we definitely want to have the feature. However,
you should read the Coding Style guide lines again. I don't have the time
to repeat them here and point out every style violation, there are quite a
few in this patch. What you do with regards to using the locale backend
seems pretty weird to me. Also, you need to define a message constant
somewhere, and it needs to be upper case, as all system message codes are.
Since there are two methods called in the BTextInput constructor now,
there should be a private _Init() method refactored from these.
--
Ticket URL: <http://dev.haiku-os.org/ticket/7002#comment:3>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
