[haiku-bugs] Re: [Haiku] #7002: Context menu for TextInput
- From: "axeld" <trac@xxxxxxxxxxxx>
- Date: Mon, 20 Dec 2010 14:26:59 -0000
#7002: Context menu for TextInput
--------------------------+------------------------------------------------
Reporter: dancxjo | Owner: axeld
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: | Version: R1/Development
Kits/Interface Kit | Keywords: context menu text edit textinput
Resolution: | Has a Patch: 1
Blocked By: | Blocking:
Platform: All |
--------------------------+------------------------------------------------
Comment (by axeld):
One of the coding style violations that you manage to disobey almost
consequently is the "two blank lines between sections" rule. You even
changed existing code to remove it at some places, that is usually a bad
idea.
Also, the declaration of the menu items does not conform to the style
guide; you should only declare one variable per type.
kClearInput should probably be renamed to kMsgClearInput, and its constant
should be a system code, like those in defined in the public headers, IIRC
they are prefixed with '_'.
There are more style violations in there, please have another look at the
coding style guide, and thanks for the code - the rest looks pretty much
okay!
--
Ticket URL: <http://dev.haiku-os.org/ticket/7002#comment:7>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
