[haiku-bugs] Re: [Haiku] #6890: [intel] can't find boot volume after r38970 (regression)

  • From: "siarzhuk" <trac@xxxxxxxxxxxx>
  • Date: Sun, 28 Nov 2010 09:46:45 -0000

#6890: [intel] can't find boot volume after r38970 (regression)
---------------------------+------------------------------
  Reporter:  diver         |        Owner:  bebop
      Type:  bug           |       Status:  assigned
  Priority:  normal        |    Milestone:  R1
 Component:  Drivers/Disk  |      Version:  R1/Development
Resolution:                |     Keywords:
Blocked By:                |  Has a Patch:  0
  Platform:  All           |     Blocking:
---------------------------+------------------------------

Comment (by siarzhuk):

 He has tested his system using r39648 with following roll-back changes:

 {{{
 Index: PartitionMap.cpp
 ===================================================================
 --- PartitionMap.cpp    (revision 39648)
 +++ PartitionMap.cpp    (working copy)
 @@ -834,6 +834,14 @@
                 off_t nextOffset = 0;
                 for (int32 i = 0; i < byOffsetCount; i++) {
                         Partition* partition = byOffset[i];
 +
 +#if 1
 +                       if (partition->Offset() < nextOffset) {
 +                               TRACE(("intel: PartitionMap::Check():
 overlapping partitions!"
 +                                       "\n"));
 +                               result = false;
 +                               break;
 +#else
                         if (partition->Offset() < nextOffset && i > 0) {
                                 Partition* previousPartition = byOffset[i
 - 1];
                                 off_t previousSize =
 previousPartition->Size()
 @@ -848,6 +856,7 @@
                                                 "size to %lld\n", i - 1,
 previousSize));
 previousPartition->SetSize(previousSize);
                                 }
 +#endif
                         }
                         nextOffset = partition->Offset() +
 partition->Size();
                 }

 }}}

 The problem disappeared and he has successfully boot his system. The
 "haiku_loader" and "intel" partition addons were replaced for this test.

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/6890#comment:4>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: