[haiku-bugs] [Haiku] #6746: jam -q bash, mkbuiltins can pollute HAIKU_TOP

  • From: "mmadia" <trac@xxxxxxxxxxxx>
  • Date: Sun, 24 Oct 2010 17:17:24 -0000

#6746: jam -q bash, mkbuiltins can pollute HAIKU_TOP
   Reporter:  mmadia        |       Owner:  bonefish
       Type:  bug           |      Status:  new
   Priority:  normal        |   Milestone:  R1
  Component:  Build System  |     Version:  R1/Development
   Keywords:                |  Blocked By:
Has a Patch:  0             |    Platform:  All
   Blocking:                |
 This occurs only when HAIKU_TOP and HAIKU_OUTPUT_DIR are different volumes
 and you build from within HAIKU_TOP.

 [browser:haiku/trunk/src/bin/bash/builtins/mkbuiltins.c#L337] has a rename
 function, which will not work across volumes and will leave a stray "mk-*"
       if (structfile)
           write_longdocs (structfile, saved_builtins);
           fclose (structfile);
           rename (temp_struct_filename, struct_filename);

 The attached patch introduces a commandline option to specify the filename
 of the temp_struct_filename, allowing the buildsystem to place it on the
 same volume as HAIKU_OUTPUT_DIR.

 I believe this to be acceptable, as the build system should be only using
 HAIKU_OUTPUT_DIR for writing (temporary) files.

Ticket URL: <http://dev.haiku-os.org/ticket/6746>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: