[haiku-bugs] Re: [Haiku] #5912: Devices localization patch
- From: "pulkomandy" <trac@xxxxxxxxxxxx>
- Date: Wed, 14 Jul 2010 16:52:45 -0000
#5912: Devices localization patch
-----------------------------------+----------------------------------------
Reporter: Karvjorm | Owner: pulkomandy
Type: enhancement | Status: assigned
Priority: normal | Milestone: R1
Component: Applications/Devices | Version: R1/alpha1
Resolution: | Keywords: Devices localization patch
Blocked By: | Has a Patch: 1
Platform: All | Blocking:
-----------------------------------+----------------------------------------
Comment (by pulkomandy):
Looks mostly fine, but there are still some details...
* Skip two lines between blocks (including #define\n\n#include and
}\n\n#undef TR_CONTEXT)
* In some places you added a space after :. That's not style-compliant
* You don't need to link "locale" in the Jamfile, only
$(HAIKU_LOCALE_LIBS).
Thanks for your efforts anyway !
--
Ticket URL: <http://dev.haiku-os.org/ticket/5912#comment:10>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
