[haiku-bugs] Re: [Haiku] #5783: [Tracker] don't try to fix executable bit on read only file systems
- From: "diver" <trac@xxxxxxxxxxxx>
- Date: Wed, 04 Sep 2013 10:43:04 -0000
#5783: [Tracker] don't try to fix executable bit on read only file systems
------------------------------------+----------------------------
Reporter: diver | Owner: axeld
Type: bug | Status: new
Priority: normal | Milestone: R1
Component: Applications/Tracker | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 0 | Platform: All
------------------------------------+----------------------------
Changes (by diver):
* cc: siarzhuk (added)
Comment:
{{{
diff --git a/src/kits/tracker/FSUtils.cpp b/src/kits/tracker/FSUtils.cpp
index 8a75bbc..152731f 100644
--- a/src/kits/tracker/FSUtils.cpp
+++ b/src/kits/tracker/FSUtils.cpp
@@ -3469,7 +3469,8 @@ _TrackerLaunchDocuments(const entry_ref*
/*doNotUse*/, const BMessage* refs,
"The file is mistakenly marked as
executable. "));
alertString.ReplaceFirst("%name", app.name);
- if (!openWithOK) {
+ BVolume volume(documentRef.device);
+ if (!openWithOK && !volume.IsReadOnly()) {
// offer the possibility to change the
permissions
alertString << B_TRANSLATE("\nShould this
be fixed?");
}}}
With the above change [http://cgit.haiku-
os.org/haiku/tree/src/kits/tracker/FSUtils.cpp?id=hrev46017#n3445
launching] a file fails with "The file is mistakenly marked as
executable." error.
--
Ticket URL: <http://dev.haiku-os.org/ticket/5783#comment:5>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
