[haiku-bugs] Re: [Haiku] #5724: Screenshot enhancement : parametric filenames
- From: "axeld" <trac@xxxxxxxxxxxx>
- Date: Thu, 15 Apr 2010 12:52:20 -0000
#5724: Screenshot enhancement : parametric filenames
-------------------------------------+--------------------------------------
Reporter: Shisui | Owner: julun
Type: enhancement | Status: new
Priority: normal | Milestone:
Component: Applications/Screenshot | Version:
Keywords: | Blockedby:
Platform: All | Blocking:
-------------------------------------+--------------------------------------
Comment(by axeld):
BTW thanks for the updated patch. However, there are still lots of coding
style issues with it, for example:
(line 140)
{{{
void* item;
for ( int32 i = 0; ; i++ ) {
item = fFilenameParameters.ItemAt(i);
}}}
Since "item" is not used outside the loop, why not declare it inside?
There shouldn't be spaces between ().
(line 447)
{{{
.Add(new BButton("", TR("Options"), new
BMessage(kShowOptions)))
}}}
What happened here?
(line 819 and others)
{{{
ScreenshotWindow::_AddFileParameterRule(FileParameter index,
const char* name)
}}}
Only one tab for indentation in this case.
(line 849)
{{{
case kImageWidth:
rule->replacementValue <<
screenshotParent->fScreenshot->Bounds().IntegerWidth() + 1;
}}}
The operator always goes to the start of the next line.
It also doesn't fix the '{' style everywhere.
Please consult http://www.haiku-os.org/development/coding-guidelines for
more information.
--
Ticket URL: <http://dev.haiku-os.org/ticket/5724#comment:6>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
