[haiku-bugs] Re: [Haiku] #5724: Screenshot enhancement : output filename specification in silent mode

  • From: "axeld" <trac@xxxxxxxxxxxx>
  • Date: Thu, 15 Apr 2010 18:28:50 -0000

#5724: Screenshot enhancement : output filename specification in silent mode
-------------------------------------+--------------------------------------
 Reporter:  Shisui                   |       Owner:  julun
     Type:  enhancement              |      Status:  new  
 Priority:  normal                   |   Milestone:       
Component:  Applications/Screenshot  |     Version:       
 Keywords:                           |   Blockedby:       
 Platform:  All                      |    Blocking:       
-------------------------------------+--------------------------------------

Comment(by axeld):

 Great, thanks! I've applied it in r36312.

 I've made a few changes, and here is why:
  * There is no reason to make the filename parameter a BString, so I
 changed it to a const char*.
  * Furthermore, a BString is empty by default, so there is no need to set
 it to "" manually.
  * Also, it should have been "const BString&" in order to save an extra
 copy when passing the object around.

 In any case, I keep this ticket open for a while to collect other opinions
 on the matter.

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/5724#comment:10>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: