[haiku-bugs] Re: [Haiku] #5706: Changed Inode ID bounds check
- From: "axeld" <trac@xxxxxxxxxxxx>
- Date: Sun, 11 Apr 2010 11:56:38 -0000
#5706: Changed Inode ID bounds check
-------------------------------------------+--------------------------------
Reporter: jvff | Owner: axeld
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: File Systems/ext2 | Version: R1/alpha1
Keywords: gsoc2010 ext2 inode NumInodes | Blockedby:
Platform: All | Blocking:
-------------------------------------------+--------------------------------
Comment(by axeld):
I like it, but I have one coding style remark, and one suggestion:
* Multiline statements after an if/for/while should be enclosed in curly
braces.
* Instead of using something like State() == 2, define constants for the
known states, and check against those.
Thanks!
--
Ticket URL: <http://dev.haiku-os.org/ticket/5706#comment:2>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
