[haiku-bugs] Re: [Haiku] #5137: [PATCH] Compressed Kernel and Modules.
- From: "stippi" <trac@xxxxxxxxxxxx>
- Date: Wed, 16 Dec 2009 23:05:43 -0000
#5137: [PATCH] Compressed Kernel and Modules.
------------------------------------+---------------------------------------
Reporter: Grey | Owner: axeld
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: System/Boot Loader | Version: R1/alpha1
Keywords: compressed kernel CELF | Blockedby:
Platform: All | Blocking:
------------------------------------+---------------------------------------
Comment(by stippi):
Thanks a lot for the patch, nice work! I've skimmed over it to see what it
does... I presume you have made some performance measurements? Can you
give some numbers as to what speed-up you have achieved? As for the patch
itself, besides the issues you already pointed out, I spotted some coding
style violations, particularily, we put spaces around operators such as +
and *. And the variable naming is always camel case, starting with lower
case for local variables. Until you get feedback from other devs, you
could improve that, since most of us are a bit particular about the coding
style... :-) The coding style document should cover almost everything, if
you are unsure about anything.
--
Ticket URL: <http://dev.haiku-os.org/ticket/5137#comment:1>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
