#5017: [Patch] Virtualmemory preflet localization ---------------------------------------+------------------------------------ Reporter: mt | Owner: pulkomandy Type: enhancement | Status: assigned Priority: normal | Milestone: R1 Component: Preferences/VirtualMemory | Version: R1/Development Keywords: | Blockedby: Platform: All | Blocking: ---------------------------------------+------------------------------------ Changes (by pulkomandy): * owner: stippi => pulkomandy * status: in-progress => assigned Comment: The patch looks fine for me, TR_MARK is used to translate the static. It doesn't do anything on the code size, but it marks the strings so they end up in the catalog. As for the string compositing, the simplest way is to use positional markers in the % escapes. Like this : TR("Physical Memory: %1$s%2$s"), bytes, label. This means "take arg 1 (bytes) firs, and arg 2 next to it. If the translator wants to get the reverse way, he translates the string with "Physical Memory: %2$s%1$s". Your code is technically perfectly fine but less useable for translators in some languages. -- Ticket URL: <http://dev.haiku-os.org/ticket/5017#comment:4> Haiku <http://dev.haiku-os.org> Haiku - the operating system.