[haiku-bugs] Re: [Haiku] #4713: [Sounds] Wrong selected sounds

  • From: "jackburton" <trac@xxxxxxxxxxxx>
  • Date: Sat, 09 Jan 2010 12:32:58 -0000

#4713: [Sounds] Wrong selected sounds
--------------------------------+-------------------------------------------
 Reporter:  mpanasyuk           |       Owner:  marcusoverhagen
     Type:  bug                 |      Status:  new            
 Priority:  normal              |   Milestone:  R1             
Component:  Preferences/Sounds  |     Version:  R1/pre-alpha1  
 Keywords:                      |   Blockedby:                 
 Platform:  All                 |    Blocking:                 
--------------------------------+-------------------------------------------

Comment(by jackburton):

 Replying to [comment:1 stimut]:

 > This stems from a BString's '=' operator treating a NULL 'const char *'
 differently to one which is an empty string. That is, the BString's value
 does not change if the '=' operator is used with a NULL.
 >
 > I've attached a small patch which fixes the problem in the Sounds
 preflet. My personal preference would be to change the implementation of
 BString to treat NULLs like empty strings, but that is quite a core
 component and I don't feel I have the authority to make that call (this
 being my first ever code contribution) :).

 I agree with you. If there aren't any api compatibility problems with that
 change, I'd like to fix that problem in BString,

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/4713#comment:2>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: