[haiku-bugs] Re: [Haiku] #3825: URL linkification in People [easy]
- From: "stippi" <trac@xxxxxxxxxxxx>
- Date: Mon, 19 Apr 2010 08:37:35 -0000
#3825: URL linkification in People [easy]
---------------------------------+------------------------------------------
Reporter: humdinger | Owner: nobody
Type: enhancement | Status: new
Priority: low | Milestone: R1
Component: Applications/People | Version:
Keywords: gsoc2010, people | Blockedby:
Platform: All | Blocking:
---------------------------------+------------------------------------------
Comment(by stippi):
Thanks for the updated patch. Since I've already provided coding snippets,
I want to point out some coding style things to improve:
* Private methods get the underscore prefix, as shown in my snippet.
* Variable names in parameters never have the f prefix, that's for member
variables. Also "label" is wrong, since it's the text, not the label.
* The naming of LoadLabels() is not good. It sounds like the control
loads label strings from somewhere and updates its label. How about
"HandleLabelInvokation()" or "HandleLabelClicked()". It could also be a
private method, with underscore prefix then.
* Why not put the check for mailto: into an else switch?
* I think my suggestion to add a TODO about _VisibleLabelBounds() only
working for right-aligned labels was a good one. :-)
* I don't know what you mean about MouseMoved(). It should work just
fine, just not over the text input, but over the label. It is good style
to indicate this otherwise hidden feature by changing the mouse cursor
shape.
--
Ticket URL: <http://dev.haiku-os.org/ticket/3825#comment:8>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
