[haiku-bugs] Re: [Haiku] #3762: PackageInstaller and handling script files
- From: "korli" <trac@xxxxxxxxxxxx>
- Date: Fri, 26 Mar 2010 17:44:44 -0000
#3762: PackageInstaller and handling script files
-------------------------------------------+--------------------------------
Reporter: sil2100 | Owner: sil2100
Type: bug | Status: in-progress
Priority: low | Milestone: Unscheduled
Component: Applications/PackageInstaller | Version: R1/pre-alpha1
Keywords: | Blockedby:
Platform: All | Blocking:
-------------------------------------------+--------------------------------
Comment(by korli):
A few things I noticed:
* ParseScript and RunScript should be prefixed with an underscore.
* if inflate_data fails, the allocated *script array is not deleted.
* code style problems, example PackageInstall.cpp line132: } <newline>
else {
* the macro RETURN_MESSAGE() is a problem IMO. I would add a method which
calls Install and post the message if needed.
--
Ticket URL: <http://dev.haiku-os.org/ticket/3762#comment:6>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
