[haiku-bugs] Re: [Haiku] #3241: Lights Off crashes on startup

  • From: "marcusoverhagen" <trac@xxxxxxxxxxxx>
  • Date: Mon, 18 Jul 2011 08:36:15 -0000

#3241: Lights Off crashes on startup
------------------------------+-----------------------------
   Reporter:  darkwyrm        |      Owner:  marcusoverhagen
       Type:  bug             |     Status:  new
   Priority:  normal          |  Milestone:  R1
  Component:  Kits/Media Kit  |    Version:  R1/pre-alpha1
 Resolution:                  |   Keywords:
 Blocked By:                  |   Blocking:
Has a Patch:  0               |   Platform:  All
------------------------------+-----------------------------

Comment (by marcusoverhagen):

 GridView does no error checking for BEntry and BFileGameSound it creates,
 and calls Preload() on them.

 Preload() alls Load()

 BFileGameSound::Load() calls BMediaTrack::ReadFrames() with
 fAudioStream->stream invalid pointer.

 When a file doesn't exist, fAudioStream->stream is invalid after
 BFileGameSound::Init().
 This Init() has some more issues as well.


 Solution: fix all the bugs. There are sooo many. Quick solution: Set
 fAudioStream to NULL on init error, and check it in Load()

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/3241#comment:7>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: