[haiku-bugs] Re: [Haiku] #3065: [StyledEdit] Bad argument type passed to function (easy)

  • From: "humdinger" <trac@xxxxxxxxxxxx>
  • Date: Fri, 03 Dec 2010 13:31:27 -0000

#3065: [StyledEdit] Bad argument type passed to function (easy)
--------------------------------------+-----------------------------
  Reporter:  diver                    |        Owner:  korli
      Type:  bug                      |       Status:  new
  Priority:  normal                   |    Milestone:  R1
 Component:  Applications/StyledEdit  |      Version:  R1/pre-alpha1
Resolution:                           |     Keywords:
Blocked By:                           |  Has a Patch:  1
  Platform:  All                      |     Blocking:
--------------------------------------+-----------------------------

Comment (by humdinger):

 I leave the competent review to our experienced devs, just this much: you
 forgot to include the declaration of {{{ bool fDiscardFakeChanged; }}} in
 StyledEditWindow.h in your patch. Also always generate a patch from {{{
 trunk/ }}}. Lastly, respect the 80 char width rule.[[BR]]
 Apart from that, I can confirm that with your patch the example file does
 indeed open in StyledEdit. I have set the "patch" flag with this ticket,
 in the hopes that when you've uploaded an updated patch someone has a look
 and applies it.[[BR]]
 Thanks very much, Marcello!

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/3065#comment:10>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: