[haiku-bugs] Re: [Haiku] #16388: Cursor does not blink as expected in Terminal

  • From: "Haiku" <trac@xxxxxxxxxxxx>
  • To: undisclosed-recipients: ;
  • Date: Fri, 18 Sep 2020 08:09:52 -0000

#16388: Cursor does not blink as expected in Terminal
------------------------------------+-------------------------------------
  Reporter:  dogcow                 |      Owner:  jackburton
      Type:  bug                    |     Status:  new
  Priority:  low                    |  Milestone:  Unscheduled
 Component:  Applications/Terminal  |    Version:  R1/Development
Resolution:                         |   Keywords:  cursor, terminal, blink
Blocked By:                         |   Blocking:
  Platform:  All                    |
------------------------------------+-------------------------------------
Comment (by jackburton):

 I think the problem is here:

 When the Terminal window is deactivated,
 TermView::_Deactivate() gets called, and calls
 TermView::SwitchCursorBlinking(false);

 TermView::SwitchCursorBlinking() sets fCursorBlinking to false.

 When the window is then activated again, TermView::_Activate() calls
 TermView::SwitchCursorBlinking(fCursorBlinking), which is always false.

 A quick fix would be changing TermView::_Activate() so that it checks the
 preference value instead of the local variable:

 PrefHandler::Default()->getBool(PREF_BLINK_CURSOR);
-- 
Ticket URL: <https://dev.haiku-os.org/ticket/16388#comment:2>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.

Other related posts: