[haiku-bugs] Re: [Haiku] #15804: WebKit: crash in incrementPageOccupancy

  • From: "Haiku" <trac@xxxxxxxxxxxx>
  • To: undisclosed-recipients: ;
  • Date: Sat, 16 May 2020 17:38:40 -0000

#15804: WebKit: crash in incrementPageOccupancy
---------------------------------------+----------------------------
  Reporter:  X512                      |      Owner:  pulkomandy
      Type:  bug                       |     Status:  new
  Priority:  normal                    |  Milestone:  Unscheduled
 Component:  Applications/WebPositive  |    Version:  R1/Development
Resolution:                            |   Keywords:
Blocked By:                            |   Blocking:
  Platform:  All                       |
---------------------------------------+----------------------------
Comment (by waddlesplash):

Adding more ifdefs will make it even less readable

 Why do we need more ifdefs? It looks to me like we can use the Linux
 ifdefs and also activate them under Haiku.

Our implementation is not identical to Linux (it uses mprotect in places
 where we need mmap, so we can't reuse these paths).

 No, it uses mprotect correctly; in fact, it does exactly what mmlr's
 suggestions above are. It also calls madvise, too, but that's fine.
-- 
Ticket URL: <https://dev.haiku-os.org/ticket/15804#comment:31>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.

Other related posts: