[haiku-bugs] Re: [Haiku] #1503: MediaPlayer doesn't remember previous volume setting

  • From: "engleek" <trac@xxxxxxxxxxxx>
  • Date: Mon, 19 Apr 2010 10:18:24 -0000

#1503: MediaPlayer doesn't remember previous volume setting
--------------------------------------+-------------------------------------
 Reporter:  scottmc                   |       Owner:  leavengood   
     Type:  enhancement               |      Status:  in-progress  
 Priority:  normal                    |   Milestone:  R1           
Component:  Applications/MediaPlayer  |     Version:  R1/pre-alpha1
 Keywords:                            |   Blockedby:               
 Platform:  All                       |    Blocking:               
--------------------------------------+-------------------------------------

Comment(by engleek):

 I agree with storing volume as a float attribute, when I started I
 followed the methods that were available in PlaylistItem for some reason.

 As for fLastPlaylistItem, my solution involved doing the loading and
 storing at the same moment, so when an item is loaded, it stores the
 volume in the last item, then restores the volume from the new item. I
 needed a place in the code from which could access the player volume and
 the playlist, and which could react to item change.

 At the point I chose, when the Message was received, the item had already
 changed, so in order to save the volume to the last played item I chose to
 store reference.
 A more elegant solution would be to let the Playlist deal with it's own
 volume data, but I don't presently know how I it could nicely access the
 Controller volume in both directions.

 If I understand your thoughts correctly, the stored value wouldn't really
 be a volume, rather a factor to reduce volume on loud items and raise it
 for quiet items. Also if media player doesn't find an volume info, it
 first looks for nearby items with the same album data,  logically starting
 with the last item (for example).

 Thanks for the reference remark, I'll keep that in mind :)

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/1503#comment:7>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: