#14983: [app_server] crashes after double clicking Audio Mixer in Cortex
----------------------------------+----------------------------
Reporter: diver | Owner: axeld
Type: bug | Status: closed
Priority: critical | Milestone: R1/beta2
Component: Servers/app_server | Version: R1/Development
Resolution: fixed | Keywords:
Blocked By: | Blocking: 15597
Has a Patch: 0 | Platform: All
----------------------------------+----------------------------
Changes (by pulkomandy):
* status: reopened => closed
* resolution: => fixed
Comment:
The issues found so far:
- BView::DragMessage does only _CheckOwnerLock() instead of
_CheckOwnerLockAndSwitchCurrent()
- I don't know if calling AS_VIEW_DRAG_IMAGE from multiple threads, and
also while dragging is happening, is a good idea (quite possibly it will
replace the bitmap while the mouse handling is drawing it or something)
- There could be missing error checks too (for example there is no
InitCheck() for the BBitmap passed as parameter in DragMessage, so we can
end up sending the invalid -1 server token to app_server)
In general, very few things are checked at the app_server_link level, and
app_server is written assuming well-behaved BView is talking to it and
nothing else. If you want to improve that, great, but it's a separate
ticket with a deep design change of how the app_server_link works, not a
simple bug report like here.
Created #15847 to track that.
--
Ticket URL: <https://dev.haiku-os.org/ticket/14983#comment:20>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.
