[haiku-bugs] Re: [Haiku] #14959: USB Ethernet adapter causing KDL

  • From: "Haiku" <trac@xxxxxxxxxxxx>
  • To: undisclosed-recipients: ;
  • Date: Fri, 15 Mar 2019 01:50:45 -0000

#14959: USB Ethernet adapter causing KDL
--------------------------------+---------------------------------------
   Reporter:  mrentropy         |      Owner:  nobody
       Type:  bug               |     Status:  new
   Priority:  normal            |  Milestone:  Unscheduled
  Component:  Drivers/USB/XHCI  |    Version:  R1/Development
 Resolution:                    |   Keywords:  ethernet,insignia,gigabit
 Blocked By:                    |   Blocking:
Has a Patch:  0                 |   Platform:  x86-64
--------------------------------+---------------------------------------

Comment (by waddlesplash):

 So, I really don't understand how I messed this up, the code looks
 perfectly fine to me. We lock the lock
 [https://github.com/haiku/haiku/blob/master/src/add-
 ons/kernel/busses/usb/xhci.cpp#L2580 once] at the top of the function;
 there is no way for mutex_lock to fail in KDEBUG mode (that I can tell),
 and then there is only one way out at the bottom, and we unlock the mutex
 there. How does this lead to a double-unlock?

-- 
Ticket URL: <https://dev.haiku-os.org/ticket/14959#comment:2>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.

Other related posts: