[haiku-bugs] Re: [Haiku] #14025: [HaikuDepot] crash in PackageInfo::Title(PackageInfo)

  • From: "Haiku" <trac@xxxxxxxxxxxx>
  • To: undisclosed-recipients: ;
  • Date: Tue, 21 May 2019 19:54:27 -0000

#14025: [HaikuDepot] crash in PackageInfo::Title(PackageInfo)
---------------------------------------+----------------------------
   Reporter:  Iosend                   |      Owner:  stippi
       Type:  bug                      |     Status:  new
   Priority:  normal                   |  Milestone:  Unscheduled
  Component:  Applications/HaikuDepot  |    Version:  R1/Development
 Resolution:                           |   Keywords:
 Blocked By:                           |   Blocking:  14184
Has a Patch:  0                        |   Platform:  All
---------------------------------------+----------------------------

Comment (by apl-haiku):

 I spent some more time on it, but am still unable to reproduce this error
 locally.  Is somebody other than vidrep able to try to reproduce this
 error following the procedures on this ticket?

 In the error trace I see the following calls in the stack trace;

 {{{
 SearchTermsFilter::AcceptsPackage(SearchTermsFilter) + 0x7f
 Model::MatchesFilter(Model) + 0x5a
 Model::CreatePackageList(Model) + 0xee
 MainWindow::_AdoptModel() + 0x25
 MainWindow::MessageReceived(BMessage*) + 0x8de
 BLooper::DispatchMessage(BMessage*, BHandler*) + 0x59
 ...
 }}}

 Without being able to check, it appears that;

 {{{
 void
 MainWindow::_AdoptModel()
 {
   fVisiblePackages = fModel.CreatePackageList();
 ...
 }}}

 ...should be locking the {{{fModel}}} across the {{{CreatePackageList()}}}
 method call.  I can't see the problem to see if this fixes it, but I think
 that this lock should be there anyway so I'll add it via PR and we can
 see.

-- 
Ticket URL: <https://dev.haiku-os.org/ticket/14025#comment:16>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.

Other related posts: