[haiku-bugs] Re: [Haiku] #13612: BTRFS: Adding write support

  • From: "hyche" <trac@xxxxxxxxxxxx>
  • Date: Tue, 15 Aug 2017 11:25:26 -0000

#13612: BTRFS: Adding write support
----------------------------------+----------------------------
   Reporter:  hyche               |      Owner:  korli
       Type:  enhancement         |     Status:  new
   Priority:  normal              |  Milestone:  Unscheduled
  Component:  File Systems/Btrfs  |    Version:  R1/Development
 Resolution:                      |   Keywords:  gsoc2017
 Blocked By:                      |   Blocking:
Has a Patch:  1                   |   Platform:  All
----------------------------------+----------------------------

Comment (by hyche):

 Replying to [comment:25 pulkomandy]:

Patch 3 doesn't look right. If you have multiple BTRFS volumes with
 different block or sector sizes, the last one to set the static variables
 will erase the value for others.
 I don't think it is valid to have volumes with different block/sector
 sizes to use them simutaneously. Because we have to format them at once.
 For instance

 {{{
 mkfs.btrfs device1 device2 device3 <-- have same block/sector size
 }}}
 Although each volume have its superblock to indicate its block/sector
 size, but they are all the same.

This is useless, delete is already doing the check:

{{{
if (fIterator != NULL)
    delete fIterator
}}}
 Thanks fix it! and new thing to learn too :)

--
Ticket URL: <https://dev.haiku-os.org/ticket/13612#comment:26>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.

Other related posts:

  1. Home
  2. haiku-bugs
  3. Archive
  4. 08-2017