[haiku-bugs] Re: [Haiku] #13590: [package_daemon] missing an icon in notification window

  • From: "humdinger" <trac@xxxxxxxxxxxx>
  • Date: Sat, 08 Jul 2017 17:32:55 -0000

#13590: [package_daemon] missing an icon in notification window
--------------------------------------+----------------------------
   Reporter:  diver                   |      Owner:  humdinger
       Type:  enhancement             |     Status:  new
   Priority:  normal                  |  Milestone:  Unscheduled
  Component:  Servers/package_daemon  |    Version:  R1/Development
 Resolution:                          |   Keywords:
 Blocked By:                          |   Blocking:
Has a Patch:  0                       |   Platform:  All
--------------------------------------+----------------------------

Comment (by humdinger):

 I attach a patch that deals with the first three items of this
 ticket.[[BR]]
 Being not much of a coder, I may not understand things correctly... but I
 never see the function
 
[http://xref.plausible.coop/source/xref/haiku/src/servers/package/PackageManager.cpp#297
 Warn()] called that does the notifications. Only the WARN() defined in
 
[http://xref.plausible.coop/source/xref/haiku/src/servers/package/DebugSupport.h#157
 DebugSupport.h#157].

 Are the strings called with WARN() supposed to be translated? There are
 some difficult ones (for me...), e.g. at
 
[http://xref.plausible.coop/source/xref/haiku/src/servers/package/Volume.cpp#1209
 Volume.cpp#1209].

 Also, more importantly, the patch doesn't build and I don't know why...
 I pretty much did the same as Brian did for his SoftwareUpdater to
 
[http://xref.plausible.coop/source/xref/haiku/src/apps/softwareupdater/CheckManager.cpp#318
 get the icon]. :)

 It fails with:
 {{{
 C++
 
../../../generated/objects/haiku/x86_gcc2/release/servers/package/PackageManager.o
 C++
 ../../../generated/objects/haiku/x86_gcc2/release/servers/package/Root.o
 In file included from /Source-
 Haiku/haiku/src/servers/package/PackageManager.h:17,
                  from /Source-Haiku/haiku/src/servers/package/Root.cpp:28:
 /Source-Haiku/haiku/headers/os/interface/Bitmap.h:117: use of `BPrivate'
 is ambiguous
 /Source-Haiku/haiku/headers/os/support/Archivable.h:17:   first declared
 as `BPrivate' here
 /Source-Haiku/haiku/headers/private/package/ActivationTransaction.h:18:
 also declared as `BPackageKit::BPrivate' here
 /Source-Haiku/haiku/headers/os/interface/Bitmap.h:117: parse error before
 `;'
 }}}
 Seems to complain about that little BBitmap... Any idea how to solve that?

--
Ticket URL: <https://dev.haiku-os.org/ticket/13590#comment:1>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.

Other related posts: