[haiku-bugs] Re: [Haiku] #12978: Tracker Get Info window layout problem

From: "tsimblist" <trac@xxxxxxxxxxxx>
Date: Mon, 09 Jan 2017 00:35:25 -0000

#12978: Tracker Get Info window layout problem
------------------------------------+----------------------------
   Reporter:  jackburton            |      Owner:  axeld
       Type:  bug                   |     Status:  closed
   Priority:  normal                |  Milestone:  Unscheduled
  Component:  Applications/Tracker  |    Version:  R1/Development
Resolution:  fixed                 |   Keywords:
Blocked By:                        |   Blocking:
Has a Patch:  1                     |   Platform:  All
------------------------------------+----------------------------

Comment (by tsimblist):

Replying to [comment:10 axeld]:

Applied in hrev50847, thanks for the patch!

I've merged the second patch into the first one -- as long as it hasn't

been committed, it's preferred to send in a new patch instead.

I've one question, though: why lines * 2 + 1? That sounds a bit magical

to me.

I tried to combine the two patches, but got frustrated. I am a newbie
with git.

The original code was:

float height = font->Size() * 15;

I reversed engineered that into 7 double spaced lines plus one extra to
make the "Permissions" fit properly in the window.

I have reviewed the coding guidelines again and realize that I should have
used an "if ... else if ..." in order to match the code that draws the
lines. I had it that way originally and changed it because I misread the
guidelines for "if/else if" with '''returns'''.

--
Ticket URL: <https://dev.haiku-os.org/ticket/12978#comment:11>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.

[haiku-bugs] Re: [Haiku] #12978: Tracker Get Info window layout problem

Other related posts: