#12945: [Screenshot] Display error messages when saving fails
----------------------------+----------------------------
Reporter: gbl08ma | Owner: nobody
Type: enhancement | Status: new
Priority: normal | Milestone: Unscheduled
Component: Applications | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
----------------------------+----------------------------
Comment (by pulkomandy):
Thanks for the patch. Some improvements would be nice:
- The code for showing the alert is a bit repetitive. It would be nice to
write it only once.
- In one case, the string passed to B_TRANSLATE is different from the
others. I would use the same string (with the error details in a %s), so
people working on localization only have to translate this part once.
- The "Error" BAlert title should be translated. It is not visible in the
window itself with the default decorator, but it is visible in Deskbar,
and could be visible with other decorators as well. A more descriptive
title ("Failed to save screenshot", for example), would be nice.
- Instead of returning B_ERROR, you could return the exact error code,
which you have stored in the status_t variable.
--
Ticket URL: <https://dev.haiku-os.org/ticket/12945#comment:2>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
