[haiku-bugs] Re: [Haiku] #12628: [regression] BBox title text has white edges

  • From: "looncraz" <trac@xxxxxxxxxxxx>
  • Date: Tue, 02 Feb 2016 05:00:15 -0000

#12628: [regression] BBox title text has white edges
----------------------------------+----------------------------
   Reporter:  waddlesplash        |      Owner:  axeld
       Type:  bug                 |     Status:  new
   Priority:  blocker             |  Milestone:  R1/beta1
  Component:  Kits/Interface Kit  |    Version:  R1/Development
 Resolution:                      |   Keywords:
 Blocked By:                      |   Blocking:
Has a Patch:  0                   |   Platform:  All
----------------------------------+----------------------------

Comment (by looncraz):

 I won't have time to address this in a proper patch for a while (I have to
 repair my virtualization setup after a system upgrade), but I believe the
 fix would be to change BBox::AttachedToWindow() to have the following:

 AdoptParentColors();

 if(Parent() == NULL || ViewColor() == B_TRANSPARENT_COLOR)
     AdoptSystemColors();

 It has something that *almost* does that at this time, but it doesn't take
 into account a potentially NULL parent.

 In addition, changing the SetViewUIColor(B_PANEL_BACKGROUND_COLOR); line
 (662) to AdoptSystemColors() would probably be a good idea.

--
Ticket URL: <https://dev.haiku-os.org/ticket/12628#comment:1>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: