#12388: Missing support for TLS SNI (easy)
--------------------------------+----------------------------
Reporter: FreeFull | Owner: axeld
Type: bug | Status: new
Priority: normal | Milestone: Unscheduled
Component: Kits/Network Kit | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
--------------------------------+----------------------------
Comment (by pulkomandy):
I think I see a bug in the patch. Sorry for not reviewing earlier.
In {{{BNetworkAddress::SetTo(const char* host, const char* service, uint32
flags) }}}, you changed the error handling. I think you forgot to change
{{{== B_OK}}} to {{{!= B_OK}}} as in the other variant. This is something
that unit tests would probably catch.
With this issue fixed the patch is ok to merge as is. I don't want to put
unit test burden on people trying to contribute to Haiku, we should fix
our own mess there...
--
Ticket URL: <https://dev.haiku-os.org/ticket/12388#comment:14>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.