[haiku-bugs] Re: [Haiku] #12241: [ShowImage] add Get info shortcut (easy)

  • From: "pulkomandy" <trac@xxxxxxxxxxxx>
  • Date: Fri, 01 Jan 2016 09:55:19 -0000

#12241: [ShowImage] add Get info shortcut (easy)
--------------------------------------+----------------------------
   Reporter:  diver                   |      Owner:  leavengood
       Type:  enhancement             |     Status:  new
   Priority:  normal                  |  Milestone:  Unscheduled
  Component:  Applications/ShowImage  |    Version:  R1/Development
 Resolution:                          |   Keywords:
 Blocked By:                          |   Blocking:
Has a Patch:  1                       |   Platform:  All
--------------------------------------+----------------------------

Comment (by pulkomandy):

 More complete code review:
 * Indent with tabs (4 columns per tab)
 * I would try to fit the menu item in one of the existing parts of the
 menu (maybe just under "move to trash"?). Putting it in its own section
 between two separators isn't useful.
 * Two blank lines between functions
 * Why inserting the method declaration between PrepareForPrint and Print?
 These two sould like they should stay together in the group of "printing"
 functions.

--
Ticket URL: <https://dev.haiku-os.org/ticket/12241#comment:4>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: