[haiku-bugs] Re: [Haiku] #11934: [PATCH] Solve memory leaks in Deskbar and some replicants.
- From: "korli" <trac@xxxxxxxxxxxx>
- Date: Tue, 31 Mar 2015 06:02:58 -0000
#11934: [PATCH] Solve memory leaks in Deskbar and some replicants.
------------------------------+----------------------------
Reporter: Barrett | Owner: stippi
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: User Interface | Version: R1/Development
Resolution: | Keywords: Deskbar
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
------------------------------+----------------------------
Comment (by korli):
{{{
- BMessage* dragMessage = NULL;
- if (message->HasMessage("be:drag_message")) {
- dragMessage = new BMessage();
- message->FindMessage("be:drag_message",
dragMessage);
- }
+ BMessage dragMessage;
+ if (message->HasMessage("be:drag_message"))
+ message->FindMessage("be:drag_message",
&dragMessage);
}}}
With this patch, MouseMoved() is later called with &dragMessage, which is
wrong. If there is no drag message, the third argument of MouseMoved()
should be NULL.
--
Ticket URL: <https://dev.haiku-os.org/ticket/11934#comment:7>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
