[haiku-bugs] Re: [Haiku] #11686: [PATCH] Convert Tracker's BPoseView and related classes over to the layout API.
- From: "diver" <trac@xxxxxxxxxxxx>
- Date: Fri, 02 Jan 2015 17:13:17 -0000
#11686: [PATCH] Convert Tracker's BPoseView and related classes over to the
layout
API.
------------------------------------+----------------------------
Reporter: waddlesplash | Owner: axeld
Type: enhancement | Status: new
Priority: low | Milestone: Unscheduled
Component: Applications/Tracker | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 0 | Platform: All
------------------------------------+----------------------------
Description changed by diver:
Old description:
> This is a significant change. I initially planned to do this starting
> with Aldeck's branch, but that turned out to not be possible due to merge
> conflicts from PM and John's work.
>
> The only known incompatibility this creates with BeOS is that Be told
> people in the Be Book ([https://www.haiku-os.org/legacy-
> docs/bebook/BFilePanel_Overview.html here]) that they could modify
> BFilePanel by probing around for the views and moving them around. The
> only application I found (so far) that does this
> [https://github.com/olta/pe/blob/0f29ad9bd84c14c99a16ebc57f49661e55254ca2/Sources/PDoc.cpp#L876
> is Pe]. However, if there are any closed-source ones, we might have to
> come up with a workaround...
>
> This fixes #4496, #3039, #3889, and possibly #8771 (Diver: can you double
> check me on all of these?).
>
> The code is currently
> [https://github.com/waddlesplash/haiku/tree/tracker_layout_new here]
> (just one commit, as all this is inter-related) and a prebuilt
> "libtracker.so" for GCC2(Hybrid) is
> [https://gist.github.com/waddlesplash/a3f9f3161f718e43e6f7 here] (put it
> in non-packaged and blacklist the system's libtracker).
>
> Other TODO:
> * I need to clean up the inset construction on the layouts
> * I need to do a go-over of the code to make sure I didn't screw
> anything obvious up
> * Diver needs to test (and whoever else wants to)
> * Axel needs to review the code (preferably someone else would too)
New description:
This is a significant change. I initially planned to do this starting with
Aldeck's branch, but that turned out to not be possible due to merge
conflicts from PM and John's work.
The only known incompatibility this creates with BeOS is that Be told
people in the Be Book ([https://www.haiku-os.org/legacy-
docs/bebook/BFilePanel_Overview.html here]) that they could modify
BFilePanel by probing around for the views and moving them around. The
only application I found (so far) that does this
[https://github.com/olta/pe/blob/0f29ad9bd84c14c99a16ebc57f49661e55254ca2/Sources/PDoc.cpp#L876
is Pe]. However, if there are any closed-source ones, we might have to
come up with a workaround...
This fixes #4996, #3039, #3889, and possibly #8771 (Diver: can you double
check me on all of these?).
The code is currently
[https://github.com/waddlesplash/haiku/tree/tracker_layout_new here] (just
one commit, as all this is inter-related) and a prebuilt "libtracker.so"
for GCC2(Hybrid) is
[https://gist.github.com/waddlesplash/a3f9f3161f718e43e6f7 here] (put it
in non-packaged and blacklist the system's libtracker).
Other TODO:
* I need to clean up the inset construction on the layouts
* I need to do a go-over of the code to make sure I didn't screw anything
obvious up
* Diver needs to test (and whoever else wants to)
* Axel needs to review the code (preferably someone else would too)
--
--
Ticket URL: <https://dev.haiku-os.org/ticket/11686#comment:3>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
